Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Issue Type in html assessment report with Issue Name field #2268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sanyamsinghal
Copy link
Collaborator

@sanyamsinghal sanyamsinghal commented Jan 29, 2025

Describe the changes in this pull request

  • in analyze issues wherever issue name is not present assuming issue type
  • using the term Issue in html report instead of Name or Type

TODO(Question): In html report, we can have a logic which check if issue.Name == "" then use issue.Type is used, since that should ideally be present for all reported issues.

image

Describe if there are any user-facing changes

How was this pull request tested?

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB Yes/No
Name registry json Yes/No
Data File Descriptor Json Yes/No
Export Snapshot Status Json Yes/No
Import Data State Yes/No
Export Status Json Yes/No
Data .sql files of tables Yes/No
Export and import data queue Yes/No
Schema Dump Yes/No
AssessmentDB Yes/No
Sizing DB Yes/No
Migration Assessment Report Json Yes/No
Callhome Json Yes/No
YugabyteD Tables Yes/No
TargetDB Metadata Tables Yes/No

@sanyamsinghal sanyamsinghal self-assigned this Jan 29, 2025
@sanyamsinghal sanyamsinghal marked this pull request as ready for review January 31, 2025 09:54
@sanyamsinghal sanyamsinghal force-pushed the sanyam/html-issuename branch 2 times, most recently from 8317729 to e92878a Compare February 3, 2025 18:33
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
All committers have signed the CLA.

Base automatically changed from sanyam/assess-html to main February 4, 2025 09:25
- in analyze issues wherever issue name is not present assuming issue type
- using the term Issue in html report instead of Name or Type
@sanyamsinghal
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants