Modified the diagnostics_test.go and added the newly created struct.

yugabyte · Feb 4, 2025 · f56ca67 · f56ca67
1 parent d197055
commit f56ca67
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/yb-voyager/src/callhome/diagnostics.go b/yb-voyager/src/callhome/diagnostics.go
@@ -128,7 +128,7 @@ type SizingCallhome struct {
 	NumShardedTables                int     `json:"num_sharded_tables"`
 	NumNodes                        float64 `json:"num_nodes"`
 	VCPUsPerInstance                int     `json:"vcpus_per_instance"`
-	MemoryPerInstance               int     `json:"mem_per_instance"`
+	MemoryPerInstance               int     `json:"memory_per_instance"`
 	OptimalSelectConnectionsPerNode int64   `json:"optimial_select_connections_per_node"`
 	OptimalInsertConnectionsPerNode int64   `json:"optimial_insert_connections_per_node"`
 	EstimatedTimeInMinForImport     float64 `json:"estimated_time_in_min_for_import"`

diff --git a/yb-voyager/src/callhome/diagnostics_test.go b/yb-voyager/src/callhome/diagnostics_test.go
@@ -77,6 +77,7 @@ func TestCallhomeStructs(t *testing.T) {
 			expectedType: struct {
 				PayloadVersion                 string               `json:"payload_version"`
 				TargetDBVersion                *ybversion.YBVersion `json:"target_db_version"`
+				Sizing                         *SizingCallhome      `json:"sizing"`
 				MigrationComplexity            string               `json:"migration_complexity"`
 				MigrationComplexityExplanation string               `json:"migration_complexity_explanation"`
 				SchemaSummary                  string               `json:"schema_summary"`
@@ -100,6 +101,22 @@ func TestCallhomeStructs(t *testing.T) {
 				ObjectType          string `json:"object_type"`
 			}{},
 		},
+		{
+			name:       "Validate SizingCallhome Struct Definition",
+			actualType: reflect.TypeOf(SizingCallhome{}),
+			expectedType: struct {
+				NumColocatedTables              int     `json:"num_colocated_tables"`
+				ColocatedReasoning              string  `json:"colocated_reasoning"`
+				NumShardedTables                int     `json:"num_sharded_tables"`
+				NumNodes                        float64 `json:"num_nodes"`
+				VCPUsPerInstance                int     `json:"vcpus_per_instance"`
+				MemoryPerInstance               int     `json:"memory_per_instance"`
+				OptimalSelectConnectionsPerNode int64   `json:"optimial_select_connections_per_node"`
+				OptimalInsertConnectionsPerNode int64   `json:"optimial_insert_connections_per_node"`
+				EstimatedTimeInMinForImport     float64 `json:"estimated_time_in_min_for_import"`
+				ParallelVoyagerJobs             float64 `json:"parallel_voyager_jobs"`
+			}{},
+		},
 		{
 			name:       "Validate AssessMigrationBulkPhasePayload Struct Definition",
 			actualType: reflect.TypeOf(AssessMigrationBulkPhasePayload{}),