Skip to content

super(..) -> super() #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KommuSoft
Copy link

@KommuSoft KommuSoft commented Mar 29, 2025

Summary by CodeRabbit

  • Refactor
    • Modernized the superclass call syntax in key components (such as error handling, middleware, and registry logic) to align with modern Python standards.
    • These updates improve code consistency and readability without affecting any existing functionality or end-user experience.

Copy link

coderabbitai bot commented Mar 29, 2025

Walkthrough

This pull request modernizes superclass constructor calls across the codebase. In three modules—exceptions, middleware, and registry—the explicit class names in super() calls have been replaced with the no-argument form. This update employs Python 3 style syntax to simplify the code without affecting the underlying behavior of exception handling, middleware initialization, or registry operations.

Changes

File(s) Change Summary
rules_light/exceptions.py, rules_light/middleware.py, rules_light/registry.py Replaced explicit superclass calls (e.g., super(ClassName, self).__init__() or __setitem__) with the simplified no-argument super() form for cleaner syntax.

Poem

I'm a little bunny with a coding hop,
Skipping over clutter till the old syntax stops.
Super calls now dance with a sleek new spin,
Making our code light from the outside in.
Hoppity cheers for this modern win!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adae5a0 and 7b24e35.

📒 Files selected for processing (3)
  • rules_light/exceptions.py (1 hunks)
  • rules_light/middleware.py (1 hunks)
  • rules_light/registry.py (1 hunks)
🔇 Additional comments (4)
rules_light/middleware.py (1)

35-40: Modernized superclass constructor call is correct.
The updated use of super().__init__() in the __init__ method is aligned with modern Python 3 practices and maintains the original functionality.

rules_light/exceptions.py (2)

10-12: Updated Denied exception constructor using modern super().
The change from the explicit super(Denied, self).__init__(...) to super().__init__(...) is correctly applied and simplifies the constructor without affecting behavior.


15-17: Modernized DoesNotExist exception constructor is correctly implemented.
Switching to super().__init__(...) for DoesNotExist maintains the intended functionality while reducing boilerplate.

rules_light/registry.py (1)

41-43: Modernized setitem method using super() is appropriate.
Replacing the explicit call with super().__setitem__(key, value) in the RuleRegistry class aligns with Python 3 style and is consistent with similar changes in other parts of the codebase.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant