Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill objectives on traitor no longer happen under 10 pop #22964

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Aquizit
Copy link
Contributor

@Aquizit Aquizit commented Jan 16, 2025

Document the changes in your pull request

Traitors no longer get kill objectives of any type when the player count is under 10.

Why is this good for the game?

No-one has fun when there are 4 crew members and the one traitor has to kill 2 of them.

This is sort of a hashed fix. It is 10 players, not 10 crew -- meaning if there are like 6 ghost roles it can still happen.
Being able to do it with like 6 players as long as there's 1 secoff works too but it's above my coding ability.

Testing

2 crew
image

Enabled and removed 3 times, no kill objectives.
image
image
image

Changelog

🆑
tweak: No more murder under 10 players
experimental: Min player number can be changed
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Jan 16, 2025
@cowbot92
Copy link
Contributor

can you actually make it so they only happen

@Aquizit
Copy link
Contributor Author

Aquizit commented Jan 16, 2025

can you actually make it so they only happen

Uh. I mean yeah just change prob(50) to prob(100) I know you're being a smartass (I think) but it's funny how easy that would be

@Moltijoe Moltijoe merged commit 1ea3ace into yogstation13:master Jan 20, 2025
15 checks passed
Yogbot-13 added a commit that referenced this pull request Jan 20, 2025
@Aquizit Aquizit deleted the kill-obj-min-pop branch January 20, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants