Fixes hop's skirt #22950
Merged
Fixes hop's skirt #22950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToasterBiome
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
For whatever reason, HoP's skirt had 'civilian' in its type path in command.dm, and this was not repeated in other parts of the code. This caused issues, such as it not showing in HoP's vendor and it causing issues with the turtle neck. This PR removes 'civilian' from its typepath, fixing the issues.
Why is this good for the game?
Fixes #22909
Testing
Skirt now shows in the vendor:
Turtleneck skirt has worn sprites:
Something that I noticed while testing this: sometimes, when switching to the turtleneck's alt for the first time, the uniform's worn sprite would turn invisible for a second before becoming the alt sprite. I do not know why it does this, but it does not stay invisible so I guess it isn't too much of a problem.
Changelog
🆑
bugfix: HoP's skirt now shows in their vendor and turtleneck skirt has worn sprites
/:cl: