Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remakes Ministation Turbine+ adds more radsuit lockers #22946

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

Ethan4303
Copy link
Member

@Ethan4303 Ethan4303 commented Jan 6, 2025

Document the changes in your pull request

Moves Turbine on Ministation so that it is connected to Atmospherics via a door
changed the room with glass floor to be similar to the room on boxstation before you enter the SMES
gave turbine its essentials, the gas sim console, radlockers

Why is this good for the game?

felt annoying having to run a horseshoe pattern every time i needed something from atmos. plus its turbine, it should be attached to atmos and not give the possibility of irradiating all of engineering to the lobby

Testing

Tested and fixed issue biome called me out for

Spriting

N/A

Wiki Documentation

image

Changelog

🆑

mapping: moved ministation turbine over to atmos, old connecting room now has some tables and stuff and extra rad lockers that were missing, gave atmos more radlockers since they were missing too

/:cl:

@Ethan4303 Ethan4303 requested a review from a team as a code owner January 6, 2025 03:01
@Ethan4303
Copy link
Member Author

side note, give me feedback on what i should do with the lattice and catwalk structure, i hate doing catwalk and lattice mapping, i have to fight myself to not make it perfectly symmetrical when possible

@github-actions github-actions bot added the Mapping Will result in a change to a map. label Jan 6, 2025
Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend moving these buttons out of the wall
image

moving this sign outside to make it more visible perhaps?
image

and resetting the APC's areastring variable so it isn't magically connected to disposals
image

@Ethan4303
Copy link
Member Author

I recommend moving these buttons out of the wall image

moving this sign outside to make it more visible perhaps? image

and resetting the APC's areastring variable so it isn't magically connected to disposals image

fixed first two, but isnt the Apc string good? i checked how the string was done on boxstation and its the same way areastring matches the area
image

Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This area is strange,

image

You have some lattices that are not nearstation here,

image
I wish this area had windows instead of all the way to the left. Also random light switch.

Overall I don't really like this move, most specifically because the top of the SM was intentionally inside the station for shenanigans, lol.

image

Also this can be moved down two tiles while we're here.

@Ethan4303 Ethan4303 requested a review from ToasterBiome January 8, 2025 13:01
@Ethan4303
Copy link
Member Author

Overall I don't really like this move, most specifically because the top of the SM was intentionally inside the station for shenanigans, lol.

i personally think that the turbine always has and should be connected to atmos, i gave it some thought on what to replace it with so there would still be something above it but kept drawing a blank on what to put back there, any ideas would be great but ill die on this hill thinking turbine should be moved

Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed first two, but isnt the Apc string good? i checked how the string was done on boxstation and its the same way areastring matches the area

I misread this mb, 'sall good

on another note I'm sure we'll put a room over the SM again someday that is pretty funny
construction room maybe who knows

@AMyriad AMyriad dismissed ToasterBiome’s stale review January 14, 2025 16:05

problems addressed

@AMyriad AMyriad merged commit 1e41ead into yogstation13:master Jan 14, 2025
15 checks passed
Yogbot-13 added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Will result in a change to a map.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants