Refactor and rewrite bloodsucker and vamp #22911
Conversation
|
fuck this |
Moltijoe
changed the title
| @@ -61,7 +57,7 @@ | |||
| /** | |||
| * Clan defines | |||
| */ | |||
| #define CLAN_NONE "Caitiff" | |||
| #define CLAN_CAITIFF "Caitiff" | |||
There was a problem hiding this comment.
naming the define CLAN_CAITIFF undermines the original intent of having it be the default NONE clan, people won't go after looking caitiff is, you should just have NONE.
There was a problem hiding this comment.
i'm not even certain i'm keeping the NONE clan
my design doc is
https://hackmd.io/@oerIqwbETomAqf6XwywK_g/SJz1A1zUyx
if you want to take a look
| return TRUE | ||
| . += "Current Frenzy Enter: [FRENZY_THRESHOLD_ENTER]" | ||
| . += "Current Frenzy Leave: [FRENZY_THRESHOLD_EXIT]" | ||
| // if(bloodsuckerdatum.has_task) |
There was a problem hiding this comment.
y did u remove total blood drank
There was a problem hiding this comment.
that is being moved elsewhere
| @@ -105,8 +83,30 @@ | |||
| TRAIT_TOXIMMUNE, | |||
| TRAIT_HARDLY_WOUNDED, | |||
| TRAIT_RESISTDAMAGESLOWDOWN, | |||
| TRAIT_UNHOLY | |||
There was a problem hiding this comment.
having trait unholy was a mistake on copy pasting on my part, it shouldn't be this way
There was a problem hiding this comment.
why hasn't it been fixed in 2 years then
There was a problem hiding this comment.
i just found out while looking through this, it shouldn't be this way cause bloodsuckers shouldn't be countered by chaps
|
not worth the effort to rework, but it's also not worth the headache to remove, so i guess it stays as is |
Why is this good for the game?
the code quality is trash
Testing
this is gonna take a while
🆑
experimental: Refactored Bloodsucker code
/:cl: