-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release steps to the buildkite pipeline #544
base: main
Are you sure you want to change the base?
Conversation
Aiming to release new gems from CI rather than manually
auto/release-gem
Outdated
# gem build pdf-reader.gemspec | ||
# GEM_HOST_API_KEY="${GEM_HOST_API_KEY}" gem push "pdf-reader-${RELEASE_VERSION}.gem" | ||
|
||
docker run -it -v "${PWD}:/work" -w /work -e GEM_HOST_API_KEY="${GEM_HOST_API_KEY}" ruby:3.4-slim bash -c "gem build pdf-reader.gemspec && gem push \"pdf-reader-${RELEASE_VERSION}.gem\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could go back to using the gem
available in ubuntu's repositories, this was just be testing to see if the newer rubygems version helped.
- specs-legacy | ||
- specs-jruby | ||
- specs-jruby-soft | ||
#branch: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncomment this before merging
auto/release-gem
Outdated
|
||
echo "--- Request rubygems token" | ||
|
||
RUBYGEMS_ROLE="rg_oidc_akr_xoy8sqmj25t8ok4rn5sq" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks secret, but not actually that secret
Noodling on some additional CI steps that will publish to rubygems.org from CI using OIDC, rather than me doing it manually from my laptop.
Partly blocked on rubygems/rubygems.org#5376, which I was able to work around but it makes the setup on rubygems.org difficult.
Hard blocked on rubygems/rubygems.org#5296 (comment), because rubygems.org recently started requiring OIDC tokens to have a
jti
claim and Buildkite doesn't include it (yet?).I also switched the pipeline.yml to DAG mode, because it's better.
I'm not using https://github.com/buildkite-plugins/rubygems-oidc-buildkite-plugin/ because it requires ruby in the CI env and I don't have it (and don't want to jump through hoops to install it)