[BUGFIX] Add custom CockroachSchemaManager and override selectTableColumns() / fixes #35 #36
+249
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes In Code
Add custom
CockroachSchemaManager
extending thePostgreSQLSchemaManager
and override theselectTableColumns()
function to add thea.attisdropped = false
flag to the SQL query.Additionally override
compileColumns
function inCockroachGrammar
-Class to fix the output of theSchema::getColumns
function.Issue ticket number / Business Case
#35
Checklist before requesting a review