Skip to content

Bug #17708: Explicitly define precision to be 15 for FormatterNumberTest::testIntlAsScientific #17714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bug #17708: Explicitly define precision to be 15 for FormatterNumberTest::testIntlAsScientific #17714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ebbef7
Fixes #17708 explicitly define precision to be 15
diego-mathis Dec 6, 2019
3f183b7
add changelog
diego-mathis Dec 6, 2019
f2248bd
readd lost empty line
diego-mathis Dec 6, 2019
a538c72
Try if this passes travis
diego-mathis Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions framework/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Yii Framework 2 Change Log
- Bug #17865: Fix invalid db component in `m180523_151638_rbac_updates_indexes_without_prefix` (rvkulikov)
- Bug #17694: Fixed Error Handler to clear registered view tags, scripts, and files when rendering error view through action view (bizley)
- Bug #17701: Throw `BadRequetHttpException` when request params can’t be bound to `int` and `float` controller action arguments (brandonkelly)
- Bug #17708: Explicitly define precision to be 15 for FormatterNumberTest::testIntlAsScientific (My6UoT9)


2.0.30 November 19, 2019
Expand Down
2 changes: 1 addition & 1 deletion tests/framework/i18n/FormatterNumberTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ public function testIntlAsScientific()
// null display
$this->assertSame($this->formatter->nullDisplay, $this->formatter->asScientific(null));

$this->assertSame('8.76543210987654E16', $this->formatter->asScientific('87654321098765436'));
$this->assertSame('8.765432109876544E16', $this->formatter->asScientific('87654321098765436'));
}

public function testAsScientific()
Expand Down