Skip to content

Conversation

@aivanouski
Copy link

@aivanouski aivanouski commented Apr 20, 2016

Q A
Is bugfix? yes
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues #9269, #11152

@ihipop
Copy link
Contributor

ihipop commented Oct 14, 2016

each() is batch() with internel iteration
i ditn't see any $split parameters in each()

@cebe
Copy link
Member

cebe commented Oct 14, 2016

right, this change is not correct.

@cebe cebe closed this Oct 14, 2016
@ihipop
Copy link
Contributor

ihipop commented Oct 15, 2016

@cebe I think the only thing to make it right is just add $split parameters in each() function, and pass it to Yii::createObject of BatchQueryResult::className() .The others are fine.
@aivanouski

@ihipop
Copy link
Contributor

ihipop commented Oct 17, 2016

anyone ?
#9269

@Sammaye
Copy link

Sammaye commented Oct 17, 2016

This PR is not correct, it is too simple for one, it does not take pre-defined offset or limit into account

@andrey-denisenko
Copy link

@Sammaye

This PR is not correct, it is too simple for one, it does not take pre-defined offset or limit into account
Your solution does that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants