Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty string support in Number field #358

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add empty string support in Number field #358

merged 1 commit into from
Jul 29, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Jul 29, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fix #356

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b65954f) to head (60cd334).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #358   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       768       769    +1     
===========================================
  Files             47        47           
  Lines           2535      2535           
===========================================
  Hits            2535      2535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team July 29, 2024 12:45
@vjik vjik added the status:code review The pull request needs review. label Jul 29, 2024
@vjik vjik merged commit 64b19c4 into master Jul 29, 2024
18 checks passed
@vjik vjik deleted the improve-number branch July 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to deal with empty string in number form field?
2 participants