-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle race condition when creating cache directory #89
Conversation
vjik
commented
Jan 11, 2025
•
edited
Loading
edited
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fix #86 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
============================================
+ Coverage 91.19% 91.66% +0.47%
Complexity 69 69
============================================
Files 1 1
Lines 159 168 +9
============================================
+ Hits 145 154 +9
Misses 14 14 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sergei Tigrov <[email protected]>
Co-authored-by: Sergei Tigrov <[email protected]>
I wonder how bad is performance hit in this case... |
Probably not much. It's not affect case when folder already exists, but in cases when need to create directory error handler costs are low compared tocost of creating a folder, aren't it? |
Right. Usually the directory will be already there. |