Skip to content

Update to PHP 8.5 #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samdark wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to PHP 8.5 #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ jobs:
- ubuntu-latest
- windows-latest
php:
- "8.2"
- "8.3"
- "8.4"
- "8.5"

steps:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/composer-dependency-analyzer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ jobs:
os:
- ubuntu-latest
php:
- "8.2"
- "8.3"
- "8.4"
- "8.5"

steps:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/static.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ jobs:
os:
- ubuntu-latest
php:
- "8.2"
- "8.3"
- "8.4"
- "8.5"

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ templates:

## Requirements

- PHP 8.2 - 8.5.
- PHP 8.5.

## Installation

Expand Down
22 changes: 11 additions & 11 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,34 +33,34 @@
"test": "codecept run"
},
"require": {
"php": "8.2 - 8.5",
"php": "^8.5.0",
"ext-filter": "*",
"httpsoft/http-message": "^1.1.6",
"psr/container": "^2.0.2",
"psr/http-factory": "^1.1",
"psr/http-message": "^2.0",
"psr/http-server-handler": "^1.0.2",
"psr/log": "^3.0.2",
"symfony/console": "^7.4.1",
"symfony/console": "^7.4.4",
"yiisoft/aliases": "^3.1.1",
"yiisoft/assets": "^5.1.2",
"yiisoft/config": "^1.6.2",
"yiisoft/csrf": "^2.2.3",
"yiisoft/data-response": "^2.1.2",
"yiisoft/definitions": "^3.4.1",
"yiisoft/di": "^1.4.1",
"yiisoft/error-handler": "^4.3.1",
"yiisoft/error-handler": "^4.3.2",
"yiisoft/html": "^3.12",
"yiisoft/http": "^1.3",
"yiisoft/input-http": "^1.0.1",
"yiisoft/log": "^2.2.0",
"yiisoft/log-target-file": "^3.1",
"yiisoft/middleware-dispatcher": "^5.4",
"yiisoft/request-provider": "^1.2",
"yiisoft/request-provider": "^1.3",
"yiisoft/router": "^4.0.2",
"yiisoft/router-fastroute": "^4.0.3",
"yiisoft/session": "^3.0.1",
"yiisoft/view": "^12.2.2",
"yiisoft/view": "^12.2.3",
"yiisoft/yii-console": "^2.4.2",
"yiisoft/yii-http": "^1.1.1",
"yiisoft/yii-runner-console": "^2.2.1",
Expand All @@ -69,15 +69,15 @@
},
"require-dev": {
"codeception/c3": "^2.9",
"codeception/codeception": "^5.3.3",
"codeception/module-asserts": "^3.2.1",
"codeception/codeception": "^5.3.5",
"codeception/module-asserts": "^3.3.0",
"codeception/module-cli": "^2.0.1",
"codeception/module-phpbrowser": "^3.0.2",
"friendsofphp/php-cs-fixer": "^3.92.3",
"phpunit/phpunit": "^11.5.46",
"rector/rector": "^2.2.14",
"friendsofphp/php-cs-fixer": "^3.94.2",
"phpunit/phpunit": "^11.5.55",
"rector/rector": "^2.3.7",
"shipmonk/composer-dependency-analyser": "^1.8.4",
"vimeo/psalm": "^6.14.2"
"vimeo/psalm": "^6.15.1"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM composer/composer:2-bin AS composer

FROM dunglas/frankenphp:1-php8.2-bookworm AS base
FROM dunglas/frankenphp:1-php8.5-bookworm AS base

RUN apt update && apt -y install \
unzip
Expand Down
2 changes: 1 addition & 1 deletion rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
__DIR__ . '/src',
__DIR__ . '/tests',
])
->withPhpSets(php82: true)
->withPhpSets(php85: true)
->withRules([
InlineConstructorDefaultToPropertyRector::class,
])
Expand Down
8 changes: 4 additions & 4 deletions src/Environment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@

final class Environment
{
public const DEV = 'dev';
public const TEST = 'test';
public const PROD = 'prod';
public const string DEV = 'dev';
public const string TEST = 'test';
public const string PROD = 'prod';

public const ENVIRONMENTS = [
public const array ENVIRONMENTS = [
self::DEV,
self::TEST,
self::PROD,
Expand Down
4 changes: 4 additions & 0 deletions src/Web/Shared/Layout/Main/MainAsset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,14 @@

final class MainAsset extends AssetBundle
{
#[\Override]

Check failure on line 11 in src/Web/Shared/Layout/Main/MainAsset.php

View workflow job for this annotation

GitHub Actions / PHP 8.5-ubuntu-latest 

InvalidAttribute: Attribute Override cannot be used on a property
public ?string $basePath = '@assets/main';
#[\Override]

Check failure on line 13 in src/Web/Shared/Layout/Main/MainAsset.php

View workflow job for this annotation

GitHub Actions / PHP 8.5-ubuntu-latest 

InvalidAttribute: Attribute Override cannot be used on a property
public ?string $baseUrl = '@assetsUrl/main';
#[\Override]

Check failure on line 15 in src/Web/Shared/Layout/Main/MainAsset.php

View workflow job for this annotation

GitHub Actions / PHP 8.5-ubuntu-latest 

InvalidAttribute: Attribute Override cannot be used on a property
public ?string $sourcePath = '@assetsSource/main';

#[\Override]

Check failure on line 18 in src/Web/Shared/Layout/Main/MainAsset.php

View workflow job for this annotation

GitHub Actions / PHP 8.5-ubuntu-latest 

InvalidAttribute: Attribute Override cannot be used on a property
Comment on lines +11 to +18
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #[\Override] attribute is being applied to property declarations, which is not supported in PHP 8.3 (the latest version with definitive documentation at my knowledge cutoff). The Override attribute was introduced in PHP 8.3 specifically for methods to ensure they actually override a parent method. Properties in PHP are simply redeclared in child classes and don't have the same override semantics. If PHP 8.5 does not support the Override attribute on properties, this code will result in fatal errors. Please verify that PHP 8.5 officially supports this syntax, or remove the Override attributes from all property declarations in this file.

Suggested change
#[\Override]
public ?string $basePath = '@assets/main';
#[\Override]
public ?string $baseUrl = '@assetsUrl/main';
#[\Override]
public ?string $sourcePath = '@assetsSource/main';
#[\Override]
public ?string $basePath = '@assets/main';
public ?string $baseUrl = '@assetsUrl/main';
public ?string $sourcePath = '@assetsSource/main';

Copilot uses AI. Check for mistakes.
public array $css = [
'site.css',
];
Expand Down
Loading