Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
=========================================
Coverage 76.96% 76.96%
Complexity 29 29
=========================================
Files 11 11
Lines 178 178
=========================================
Hits 137 137
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Removes the file-based log target dependency and configuration, relying solely on stream-based logging for Docker and ./yii serve setups.
Changes:
- Replaced
FileTargetusage withStreamTargetin the bootstrap temporary error handler (public/index.php). - Removed
FileTargetfrom DI logger target configuration (config/common/di/logger.php). - Dropped
yiisoft/log-target-filefrom Composer dependencies (composer.json).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| public/index.php | Switches the temporary container-building logger from file output to stream output. |
| config/common/di/logger.php | Removes FileTarget from configured logger targets, leaving StreamTarget. |
| composer.json | Removes the yiisoft/log-target-file package requirement since it’s no longer used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File target isn't needed for Docker-based setup as well as for
./yii serve.