Initial Structure #6
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASlowCheetah
reviewed
Aug 6, 2021
| contract YakAVAX is ERC20 { | ||
| contract YakAVAX is ERC20, Ownable { | ||
| IPair private swapPair; | ||
| bool private swapsEnabled; |
Collaborator
There was a problem hiding this comment.
We need an admin function to disabled it and re-enable
| } | ||
|
|
||
| function unwrap(uint amount) public { | ||
| _burn(msg.sender,amount); |
Collaborator
There was a problem hiding this comment.
I think it's a good idea to require that the contract has the underlying AVAX available
| _; | ||
| } | ||
|
|
||
| receive() external payable { |
Collaborator
There was a problem hiding this comment.
MiniYak does not need to deal with payable, it'll receive YakToken which is ERC20 and wrap it
| } | ||
|
|
||
| function unwrap(uint amount) public { | ||
| _burn(msg.sender,amount.div(mini)); |
Collaborator
There was a problem hiding this comment.
we should require here that the amount is bigger than mini, otherwise the division will yield the result of 0.
| import "../libs/openzeppelin/utils/math/SafeMath.sol"; | ||
|
|
||
| contract MiniYak is ERC20 { | ||
| contract MiniYak is ERC20, Ownable { |
Collaborator
There was a problem hiding this comment.
We need to limit the transfer function to only transfer values higher than mini, users with less mYak than the defined mini would cause problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WE can either have an interface implementing the common methods., and leave them for now in their respective contracts.
we will be having a proxy contract which connects stable swap of Gondola to do swapFromAVAX/swapToAVAX methods.
We have a masterchef which can distribute rewards