Add SubsetProfile to subsetting function to add OS/2 table for browser #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc042e8.
fschutt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now generates proper subsetted fonts for use in browsers (in the test case, Klei.otf before is 204 KB, after subsetting it's only 24 KB). Includes a bugfix to stop encoding MacRoman characters into the cmap table, as browsers cannot load them (see #111).
Note: This PR is probably critique-worthy due to API breakage, but it at least works properly and it would enable lots of new opportunities for allsorts, especially as a "web optimization" tool, so it's quite an important PR.
Includes #110 (update the brotli decoder version).