Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: switch from CJS to ESM and bump Yeoman packages #269

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 20, 2025

Purpose of this pull request?

Fixes #265.

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain: package dependencies and module update

What changes did you make?

  • Adds "type": "module" to the package.json
  • Bumps all Yeoman dependencies to the latest: in particular the production deps yeoman-generator and yosay
  • Bumps the package.json and build.yml Node.js versions to 18+
  • WIP: Bumps Jest and switches it to its experimental ESM support

Is there anything you'd like reviewers to focus on?

I opted not to update other dependencies such as Chalk to keep the change minimal. I'd suggest we hold off releasing a new major version with these changes until those come in too

BREAKING CHANGE: Updates the Node.js engine minimum to ^18.17.0 || >=20.5.0 to align with the current "yeoman-generator" minimums.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix!: switch from CJS to ESM and bump Yeoman packages feat!: switch from CJS to ESM and bump Yeoman packages Mar 20, 2025
Copy link

socket-security bot commented Mar 20, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jest/[email protected]29.7.0 Transitive: eval +17 922 kB simenb
npm/[email protected] environment Transitive: filesystem, shell +5 65.1 kB kentcdodds

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@JoshuaKGoldberg
Copy link
Contributor Author

Partially blocked by #270 -> #271.

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
Known malware npm/@jridgewell/[email protected]
  • Note: Malicious code in gen-mapping (npm) Source: ghsa-malware (b4eec31ee330eb33aaa0bd7ce9a12d554bd6cad4d845e221ee1c01d5942a5ca3) Any computer that has this package installed or running should be considered fully compromised. All secrets and keys stored on that computer should be rotated immediately from a different computer. The package should be removed, but as full control of the computer may have been given to an outside entity, there is no guarantee that removing the package will remove all malicious software resulting from installing it.
🚫

View full report↗︎

Next steps

What is known malware?

This package is malware. We have asked the package registry to remove it.

It is strongly recommended that malware is removed from your codebase.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from CJS (CommonJS) to ESM (ECMAScript Modules)
1 participant