feat: build and run from Docker Support #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build and run the generator from docker image support added. The main aim and motivation behind doing this is, because of a no. of different generator are there, which are compatible and works with the different version of generator and also might be incompatible with other generator or versions of generator Signed-off-by: Pratik Raj <[email protected]>
| echo 'yeoman:yeoman' |chpasswd && \ | ||
| mkdir /home/yeoman/generator && \ | ||
| export DEBIAN_FRONTEND=noninteractive && \ | ||
| export TZ=Europe\Paris && \ |
Member
There was a problem hiding this comment.
Why the TZ should be Paris? Do we require to have TZ specifically defined ?
I believe that the user can always provide that as a env argument:
docker run -rm -e TZ=Europe/Madrid -it myimage
Co-authored-by: Ulises Gascón <[email protected]>
Contributor
|
👋 Just following up @UlisesGascon, can we merge & release this? Are there any blockers? Seems like a non-breaking change to me? |
Member
|
I will like to make some additional work, like update the base image, node version... and include an step in the CI to check that this is working. I will open a new PR probably with all the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and run the generator from docker image support added.
The main aim and motivation behind doing this is, because
of a no. of different generator are there,
which are compatible and works with the different version of generator
and also might be incompatible with other generator or versions of generator
Signed-off-by: Pratik Raj [email protected]