Skip to content

Starting to explore Maxmind API decoupling (Signature clashes) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

benjaminpick
Copy link
Member

I don't want to extend Maxmind classes anymore (or as less as
possible/reasonable), instead wrapping them with my own types.

  • My readers should always return my City model
  • This means, the Maxmind Reader class in manual.php needs to be wrapped
  • Can the model stay extended?

Reason: PHP 7 Typing is helpful, but when different plugins use different versions of the Maxmind library, everything goes downhill.
See https://wordpress.org/support/topic/maxmind-lib-incompabilities-meta-ticket/

@benjaminpick benjaminpick changed the title Starting to explore API decoupling (Signature clashes) Starting to explore Maxmind API decoupling (Signature clashes) Mar 3, 2021
@benjaminpick
Copy link
Member Author

I guess long-term we will need to use something like php-scoper...
https://developer.yoast.com/blog/safely-using-php-dependencies-in-the-wordpress-ecosystem/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant