Starting to explore Maxmind API decoupling (Signature clashes) #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't want to extend Maxmind classes anymore (or as less as
possible/reasonable), instead wrapping them with my own types.
Reason: PHP 7 Typing is helpful, but when different plugins use different versions of the Maxmind library, everything goes downhill.
See https://wordpress.org/support/topic/maxmind-lib-incompabilities-meta-ticket/