Refactor Parser #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

spoluyan wants to merge 1 commit into yegor256:master from spoluyan:master

spoluyan commented Oct 19, 2016 •

edited

Loading

Refactoring list:

Use interface with implementation
Rename Parser to File
Move duplicated logic to if-case
Little optimization of reading (StringBuilder)
Move magic number 0x80 to constant
Try-with-resources in order to release streams
JavaDoc

Future possible refactorings and improvements:

Create unit tests
Rename File to something more sensible
Optimize I/O operations (with Buffered reader/writer or Java NIO or something else...)


          Refactor Parser

2dcd299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet