Skip to content

Fixed github_token variable in SLO-report workflow #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025
Merged

Conversation

kprokopenko
Copy link
Collaborator

@kprokopenko kprokopenko commented Jun 26, 2025

Corrected input parameter names for the slo report action.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Copy link

github-actions bot commented Jun 26, 2025

summary

Base version: v3.111.1 (master)
Suggested version: v3.111.2

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (d0cc153) to head (3638bbe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
- Coverage   70.72%   70.69%   -0.03%     
==========================================
  Files         386      386              
  Lines       40234    40234              
==========================================
- Hits        28456    28445      -11     
- Misses      10605    10616      +11     
  Partials     1173     1173              
Flag Coverage Δ
experiment 70.20% <ø> (-0.10%) ⬇️
go-1.21.x 68.35% <ø> (-0.02%) ⬇️
go-1.24.x 70.65% <ø> (-0.08%) ⬇️
integration 53.46% <ø> (-0.01%) ⬇️
macOS 40.35% <ø> (-0.01%) ⬇️
ubuntu 70.69% <ø> (-0.03%) ⬇️
unit 40.36% <ø> (-0.01%) ⬇️
windows 40.36% <ø> (+0.02%) ⬆️
ydb-24.4 52.45% <ø> (-0.18%) ⬇️
ydb-25.1 53.33% <ø> (-0.05%) ⬇️
ydb-latest 52.94% <ø> (-0.10%) ⬇️
ydb-nightly 70.20% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kprokopenko kprokopenko requested review from asmyasnikov and polRk June 27, 2025 08:05
@polRk polRk requested a review from Copilot June 27, 2025 08:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR fixes the SLO report workflow by correcting the incorrect token variable and updating the associated parameter names.

  • Updated CHANGELOG to reflect the bugfix.
  • Renamed workflow inputs from "token" and "run_id" to "github_token" and "github_run_id" in the workflow file.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
CHANGELOG.md Added entry to document the workflow bug fix
.github/workflows/slo-report.yml Corrected input parameter names for the report action

@polRk polRk merged commit e017818 into master Jun 27, 2025
24 checks passed
@polRk polRk deleted the slo-report-fix branch June 27, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants