fixed redundant defer in sessionCore.closeOnce #1817
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summaryBase version: v3.110.2-0.20250617155334-3510af897320 (master) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
- Coverage 70.80% 70.63% -0.18%
==========================================
Files 385 385
Lines 40211 40211
==========================================
- Hits 28473 28404 -69
- Misses 10574 10626 +52
- Partials 1164 1181 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kprokopenko
reviewed
Jun 23, 2025
| @@ -198,8 +198,8 @@ func (core *sessionCore) attach(ctx context.Context) (finalErr error) { | |||
| } | |||
|
|
|||
| core.closeOnce = sync.OnceFunc(func() { | |||
| defer close(core.done) | |||
There was a problem hiding this comment.
Maybe we should keep defer close()?
kprokopenko
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.