refactor: migrate TenantOverview to ts #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Aug 23, 2023
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx
Outdated
Show resolved
Hide resolved
artemmufazalov
requested changes
Aug 24, 2023
| withLeftTrim | ||
| hasClipboardButton={tenant} | ||
| hasClipboardButton={!!tenant} |
There was a problem hiding this comment.
Why do you need !!? Doesn't Boolean(tenant) suit here?
src/store/reducers/tenants/utils.ts
Outdated
| @@ -2,7 +2,7 @@ import type {TTenant} from '../../../types/api/tenant'; | |||
| import {isNumeric} from '../../../utils/utils'; | |||
|
|
|||
| const getControlPlaneValue = (tenant: TTenant) => { | |||
| const parts = tenant.Name.split('/'); | |||
| const parts = tenant.Name ? tenant.Name.split('/') : []; | |||
There was a problem hiding this comment.
It can be simplified
const parts = tenant.Name?.split('/');
const defaultValue = parts?.length ? parts[parts.length - 1] : '—';
artemmufazalov
approved these changes
Aug 24, 2023
krosy1337
force-pushed
the
refactor-tenant-overview
branch
from
9610270 to
b5f2937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.