Skip to content

fix(PDisk): display vdisks donors #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix(PDisk): display vdisks donors #327

merged 1 commit into from
Mar 3, 2023

Conversation

ariser
Copy link
Contributor

@ariser ariser commented Mar 2, 2023

No description provided.

@ariser ariser requested a review from artemmufazalov March 2, 2023 13:05
@ariser ariser force-pushed the donors-on-pdisks branch from b1c44ed to 9fb2166 Compare March 2, 2023 13:19
return (
<VDisk
compact
data={donor}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that in this case not full donors will be without Donor label. It should be added manually via DonorMode: true property as it is in StorageGroups

flexGrow: Number(vdisk.AllocatedSize) || 1,
}}
>
{donors && donors.length ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a request, but a suggestion. Since similar logic for processing and displaying VDisks and their donors is used in two places, maybe it makes sense to create some VDisksWrapper, that will incapsulate the logic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure yet. They are similar, but still different enough to make a common component excessively complex

@ariser ariser force-pushed the donors-on-pdisks branch from 9fb2166 to 03b0b51 Compare March 3, 2023 12:21
@ariser ariser force-pushed the donors-on-pdisks branch from 03b0b51 to 71b89c6 Compare March 3, 2023 12:23
@ariser ariser merged commit 8b39b01 into main Mar 3, 2023
@ariser ariser deleted the donors-on-pdisks branch March 3, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants