fix(PDisk): display vdisks donors #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Mar 3, 2023
| return ( | ||
| <VDisk | ||
| compact | ||
| data={donor} |
There was a problem hiding this comment.
It seems that in this case not full donors will be without Donor label. It should be added manually via DonorMode: true property as it is in StorageGroups
| flexGrow: Number(vdisk.AllocatedSize) || 1, | ||
| }} | ||
| > | ||
| {donors && donors.length ? ( |
There was a problem hiding this comment.
Not a request, but a suggestion. Since similar logic for processing and displaying VDisks and their donors is used in two places, maybe it makes sense to create some VDisksWrapper, that will incapsulate the logic?
There was a problem hiding this comment.
Not sure yet. They are similar, but still different enough to make a common component excessively complex
artemmufazalov
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.