feat: manage schema object permissions #2398
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
reviewed
Jun 16, 2025
|
|
||
| const {handleShowGrantAccessChange} = useTenantQueryParams(); | ||
|
|
||
| const loading = isFetching && !currentData; |
There was a problem hiding this comment.
why cant isLoading be used here?
astandrik
reviewed
Jun 16, 2025
| <Dialog open={open} size="s" onClose={onClose}> | ||
| <Dialog.Header caption={i18n('action_change-owner')} /> | ||
| <form | ||
| onSubmit={(e) => { |
There was a problem hiding this comment.
AFAIK We use react-hook-form for forms in this project
astandrik
reviewed
Jun 16, 2025
| return ( | ||
| <Dialog open={open} size="s" onClose={onClose}> | ||
| <Dialog.Header caption={i18n('label_revoke-all-rights')} /> | ||
| <form |
There was a problem hiding this comment.
Why do we need form here?
astandrik
reviewed
Jun 16, 2025
|
|
||
| export const block = cn('ydb-grant-access'); | ||
|
|
||
| export const HumanReadableRights: Record<string, number> = { |
There was a problem hiding this comment.
RightsCodes ? or AccessRights. Dont think numbers are human-readable
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a full-featured UI for managing schema object permissions, migrates the old ACL section into Diagnostics, and deprecates the legacy Acl view in favor of an “Access” tab.
- Add a GrantAccess drawer component to grant or revoke permissions on schema objects.
- Create an “Access” diagnostics tab with AccessRights components (owner display, rights table, dialogs).
- Deprecate the old Acl component and redirect users to the new Diagnostics Access tab.
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/containers/Tenant/GrantAccess/GrantAccess.tsx | Add GrantAccess drawer component and logic |
| src/containers/Tenant/GrantAccess/GrantAccess.scss | Styles for the GrantAccess drawer |
| src/containers/Tenant/Diagnostics/DiagnosticsPages.ts | Include “access” in diagnostics tab lists |
| src/containers/Tenant/Diagnostics/Diagnostics.tsx | Render AccessRights when “access” tab is active |
| src/containers/Tenant/Diagnostics/AccessRights/shared.ts | Define BEM block for AccessRights |
| src/containers/Tenant/Diagnostics/AccessRights/i18n/index.ts | Register i18n keyset for AccessRights |
| src/containers/Tenant/Diagnostics/AccessRights/i18n/en.json | Add English translations for AccessRights UI |
| src/containers/Tenant/Diagnostics/AccessRights/components/RightsTable/columns.tsx | Define columns and headers for rights table |
| src/containers/Tenant/Diagnostics/AccessRights/components/RightsTable/RightsTable.tsx | Implement resizable data table for rights |
| src/containers/Tenant/Diagnostics/AccessRights/components/RightsTable/RevokeAllRightsDialog.tsx | Dialog component to revoke all explicit rights |
| src/containers/Tenant/Diagnostics/AccessRights/components/RightsTable/Actions.tsx | Actions for granting and revoking rights per subject |
| src/containers/Tenant/Diagnostics/AccessRights/components/Owner.tsx | Display and edit current object owner |
| src/containers/Tenant/Diagnostics/AccessRights/components/ChangeOwnerDialog.tsx | Dialog component to change object owner |
| src/containers/Tenant/Diagnostics/AccessRights/AccessRights.tsx | Main AccessRights view combining owner and rights table |
| src/containers/Tenant/Diagnostics/AccessRights/AccessRights.scss | Styles for AccessRights components |
| src/containers/Tenant/Acl/i18n/en.json | Remove old ACL keys, add redirect message |
| src/containers/Tenant/Acl/Acl.tsx | Replace Acl with button that opens Diagnostics “Access” |
| src/containers/Tenant/Acl/Acl.scss | Remove legacy Acl styles |
| src/components/SubjectWithAvatar/SubjectWithAvatar.tsx | Introduce SubjectWithAvatar component for subject display |
| src/components/SubjectWithAvatar/SubjectWithAvatar.scss | Styles for SubjectWithAvatar |
Comments suppressed due to low confidence (5)
src/containers/Tenant/GrantAccess/GrantAccess.tsx:33
- [nitpick] The new GrantAccess component contains complex state and API logic but lacks accompanying unit or integration tests. Consider adding tests to verify rights selection, save/discard behavior, and error handling.
export function GrantAccess({handleCloseDrawer}: GrantAccessProps) {
src/containers/Tenant/GrantAccess/GrantAccess.tsx:24
- The Import of './shared' for the BEM block helper will fail because there is no shared.ts in the GrantAccess folder. Consider adding a shared.ts file exporting the block utility or updating the import to point to an existing module.
import {block} from './shared';
src/containers/Tenant/Diagnostics/AccessRights/i18n/en.json:9
- The key 'descrtiption_empty-rights' contains a typo; it should be 'description_empty-rights'.
"descrtiption_empty-rights": "No access rights",
src/containers/Tenant/Diagnostics/AccessRights/i18n/en.json:10
- The key 'decription_enter-subject' contains a typo; it should be 'description_enter-subject'.
"decription_enter-subject": "Enter subject",
src/containers/Tenant/Diagnostics/AccessRights/i18n/en.json:18
- The key 'descripition_no-rights-to-revoke' contains a typo; it should be 'description_no-rights-to-revoke'.
"descripition_no-rights-to-revoke": "No rights to revoke",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand
closes #2353
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: 🔺
Current: 83.90 MB | Main: 83.77 MB
Diff: +0.13 MB (0.15%)
ℹ️ CI Information