feat: side panel aka refrigerator for query text in top queries #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
force-pushed
the
astandrik.2079
branch
from
3ea2bd5 to
89ed060
Compare
|
fixed |
|
should fix design review now |
astandrik
force-pushed
the
astandrik.2079
branch
from
702d798 to
8d69beb
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a side panel ("refrigerator") to display detailed query text and related information in the Top Queries view. Key changes include:
- Updating sorting behavior in Top Queries by accepting an optional initial sort parameter.
- Adding a new drawer component for displaying query details.
- Refactoring row selection and active state highlighting logic in both TopQueriesData and RunningQueriesData.
Reviewed Changes
Copilot reviewed 19 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/containers/Tenant/Diagnostics/TopQueries/utils.ts | Adds an optional initialSort parameter and a new utility to create InfoViewer items. |
| src/containers/Tenant/Diagnostics/TopQueries/hooks/useSetSelectedTopQueryRowFromParams.ts | Introduces a hook to select a query row based on URL params. |
| src/containers/Tenant/Diagnostics/TopQueries/hooks/useGetSelectedRowTableSort.ts | Adds support for retrieving sort order from URL params. |
| src/containers/Tenant/Diagnostics/TopQueries/columns/constants.ts | Updates query columns by adding a new 'QueryHash' column. |
| src/containers/Tenant/Diagnostics/TopQueries/columns/columns.tsx | Adjusts the ordering of columns for running queries. |
| src/containers/Tenant/Diagnostics/TopQueries/TopQueriesData.tsx | Refactors row click handling and integrates the new query details drawer. |
| src/containers/Tenant/Diagnostics/TopQueries/TopQueries.tsx | Removes now-unused row click handlers in favor of the new drawer logic. |
| src/containers/Tenant/Diagnostics/TopQueries/RunningQueriesData.tsx | Applies similar refactoring as TopQueriesData for consistency in handling selected rows and drawer display. |
| src/containers/Tenant/Diagnostics/TopQueries/QueryDetails/* | New files for rendering query details including the drawer content and copy link button. |
| src/containers/Drawer/Drawer.tsx | Implements a new drawer container and item wrapper used across query details views. |
| src/components/SyntaxHighlighter/YDBSyntaxHighlighter.tsx | Enhances the syntax highlighter with dynamic padding based on clipboard button settings. |
| src/components/Search/Search.tsx | Adds support for passing an input ref to the Search component. |
| src/containers/Tenant/Diagnostics/Diagnostics.tsx | Wraps page content in the new Drawer container to support drawer overlays. |
Files not reviewed (5)
- src/containers/Drawer/Drawer.scss: Language not supported
- src/containers/Tenant/Diagnostics/Diagnostics.scss: Language not supported
- src/containers/Tenant/Diagnostics/TopQueries/QueryDetails/QueryDetails.scss: Language not supported
- src/containers/Tenant/Diagnostics/TopQueries/TopQueries.scss: Language not supported
- src/containers/Tenant/Diagnostics/TopQueries/i18n/en.json: Language not supported
src/containers/Tenant/Diagnostics/TopQueries/RunningQueriesData.tsx
Outdated
Show resolved
Hide resolved
|
@artemmufazalov @Raubzeug ping |
Raubzeug
requested changes
Apr 24, 2025
| withClipboardButton.alwaysVisible | ||
| ) { | ||
| if (withClipboardButton.withLabel) { | ||
| paddingStyles = {paddingRight: 80}; |
| </div> | ||
| </div> | ||
|
|
||
| <Fullscreen> |
There was a problem hiding this comment.
Decided to get rid of Fullscreen view, isn't it?
| } | ||
|
|
||
| return ( | ||
| <div className={b('not-found-container')}> |
There was a problem hiding this comment.
Maybe separate component?
|
|
decided to merge refrigerator independently #2224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2079
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 83.43 MB | Main: 83.37 MB
Diff: +0.06 MB (0.07%)
ℹ️ CI Information