Skip to content

Conversation

Kludex
Copy link
Collaborator

@Kludex Kludex commented Nov 14, 2021

image

@ycd There is a need to update the images, but I don't know how you generate them.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #57 (1825c75) into master (510ea4e) will increase coverage by 3.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   83.68%   87.11%   +3.42%     
==========================================
  Files           7        7              
  Lines         141      163      +22     
==========================================
+ Hits          118      142      +24     
+ Misses         23       21       -2     
Impacted Files Coverage Δ
manage_fastapi/helpers.py 81.81% <100.00%> (+18.18%) ⬆️
manage_fastapi/main.py 85.41% <100.00%> (+12.44%) ⬆️
manage_fastapi/config.py 71.42% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510ea4e...1825c75. Read the comment docs.

@Kludex Kludex requested review from ycd and removed request for ycd December 4, 2021 10:14
@ycd
Copy link
Owner

ycd commented Jan 6, 2022

@Kludex we can merge this too if you want, then i can add images JFYK.

PS: I use carbon.now.sh to generate those images 😀

@Kludex
Copy link
Collaborator Author

Kludex commented Jan 6, 2022

I need to check the import again, I think I'm missing some error handling. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants