Skip to content

lockfile optimized #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2017
Merged

lockfile optimized #3715

merged 1 commit into from
Jun 24, 2017

Conversation

bestander
Copy link
Member

just updated lockfile that selfupdates after install

@bestander bestander merged commit fe34bb0 into yarnpkg:master Jun 24, 2017
version "1.7.1"
resolved "https://registry.yarnpkg.com/istanbul-lib-instrument/-/istanbul-lib-instrument-1.7.1.tgz#169e31bc62c778851a99439dd99c3cc12184d360"
istanbul-lib-instrument@^1.7.2:
version "1.7.2"
Copy link
Contributor

@SimenB SimenB Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this deduped away?

I ask because my pet peeve with yarn is that doing yarn on empty node_modules or yarn --force with node_modules will dedupe it, but running yarn dedupe cheekily says that deduping is done by default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently Yarn does deduping on the go "for free", this PR should address it #3729.

I think deduping should be either during upgrade operations or when deduping was requested with a command.
Not sure if --force should dedupe

Copy link
Contributor

@SimenB SimenB Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will yarn dedupe become a thing? Right now (with v0.27.5) I'm stuck manually deduping the lockfile, which really sucks.

error The dedupe command isn't necessary. yarn install will already dedupe.

This is a lie

Not sure if --force should dedupe

I agree it shouldn't, but removing the capability without adding some other way to dedupe makes me sad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @SimenB, we just had to mitigate the issue of Yarn being too eager to dedupe the packages during any installation which resulted in unexpdected behavior.

Please chime in into this issue #3778 and help out to resolve it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't know about that issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants