Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pnp): support require(esm) #6639

Merged
merged 2 commits into from
Dec 28, 2024
Merged

fix(pnp): support require(esm) #6639

merged 2 commits into from
Dec 28, 2024

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Dec 23, 2024 •
edited
Loading

What's the problem this PR addresses?

Node.js supports require(esm) now so we can avoid throwing an error if support is enabled.

Fixes #6336
Ref nodejs/citgm#1086

How did you fix it?

Avoid throwing ERR_REQUIRE_ESM if process.features.require_module is truthy.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

This was referenced Dec 23, 2024
Open
Closed
@arcanis arcanis merged commit 3978649 into master Dec 28, 2024
26 checks passed
@arcanis arcanis deleted the merceyz/fix/pnp-require-esm branch December 28, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug?]: ERR_REQUIRE_ESM in Yarn PnP mode using Node.js 22 with --experimental-require-module flag
2 participants
@merceyz @arcanis