Skip to content

Correct declared dependencies #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reitzmichnicht
Copy link

As spring-hibernate-query-utils is included as library in other projects it should only declare transitive dependencies it really needs.

I cleaned up your dependency section, removed starters from compile scope. moved a lot to the test scope and declared the annotation processor as optional.

Annotation processors should not be declared as transitive dependency.
Do not use starter dependencies.
@yannbriancon
Copy link
Owner

Great improvements, I will integrate them soon.
Thanks @reitzmichnicht !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants