Feature/filter for queries #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelstein
force-pushed
the
feature/filter_for_queries
branch
from
452d9c7 to
451a612
Compare
samuelstein
force-pushed
the
feature/filter_for_queries
branch
from
40f5ed4 to
24d2b6c
Compare
|
please review @yannbriancon |
yannbriancon
requested changes
Nov 17, 2021
src/main/java/com/yannbriancon/interceptor/HibernateQueryInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yannbriancon/interceptor/HibernateQueryInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yannbriancon/interceptor/HibernateQueryInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yannbriancon/interceptor/HibernateQueryInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yannbriancon/interceptor/HibernateQueryInterceptor.java
Outdated
Show resolved
Hide resolved
|
|
||
| @ParameterizedTest | ||
| @MethodSource("prepareQueryCountWithStartsWithFilterData") | ||
| void queryCountWithStartsWithFilter(String filter, int expectedQueryCount) { |
There was a problem hiding this comment.
Good test!
Please add tests to catch the bugs explained in my comments.
There was a problem hiding this comment.
Thx. Do you mean i should do a multithreaded test with TestNG for example?
…ceptor.java Co-authored-by: Yann Briançon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello,
i implemented the feature: #14.
please have a look