[perforator] Unify log message style

commit_hash:76dc66f7887fd844743c7ff5760315f19c144ac2
yandex · Feb 19, 2025 · b0ca371 · b0ca371
1 parent 04378ca
commit b0ca371
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/perforator/agent/collector/pkg/dso/map.go b/perforator/agent/collector/pkg/dso/map.go
@@ -103,10 +103,10 @@ func NewRegistry(l xlog.Logger, m metrics.Registry, manager *bpf.BPFBinaryManage
 // Preconditions: d.usagemu is locked.
 func (d *Registry) updateResourceUsageMetrics(ctx context.Context) {
 	if d.cachedPages < 0 {
-		d.l.Error(ctx, "cachedPages underflow")
+		d.l.Error(ctx, "Malformed unwind page table stats: cachedPages underflow")
 	}
 	if d.usedPages < 0 {
-		d.l.Error(ctx, "usedPages underflow")
+		d.l.Error(ctx, "Malformed unwind page table stats: usedPages underflow")
 	}
 	d.metrics.cachedPages.Set(float64(d.cachedPages))
 	d.metrics.usedPages.Set(float64(d.usedPages))

diff --git a/perforator/internal/symbolizer/quality_monitoring/cmd/main.go b/perforator/internal/symbolizer/quality_monitoring/cmd/main.go
@@ -44,7 +44,7 @@ func main() {
 			MetricsPort: *metricsPort,
 		})
 	if err != nil {
-		logger.Error("service is stoping with error", log.Error(err))
+		logger.Error("Service is stopping", log.Error(err))
 	}
 }
 

diff --git a/perforator/internal/symbolizer/quality_monitoring/internal/service/service.go b/perforator/internal/symbolizer/quality_monitoring/internal/service/service.go
@@ -123,7 +123,7 @@ func (s *MonitoringService) gatherServicesMetrics(ctx context.Context, logger lo
 		return err
 	}
 
-	logger.Debug("number of services", log.Int("number of services", len(services)))
+	logger.Debug("Number of services", log.Int("number of services", len(services)))
 
 	var wg sync.WaitGroup
 	servicesCh := make(chan *proto.ServiceMeta)

diff --git a/perforator/pkg/storage/client/client.go b/perforator/pkg/storage/client/client.go
@@ -336,7 +336,7 @@ func (c *Client) PushBinary(ctx context.Context, buildID string) (io.WriteCloser
 	var pushBinaryClient perforatorstorage.PerforatorStorage_PushBinaryClient
 	pushBinaryClient, err = c.client.PushBinary(ctx)
 	if err != nil {
-		l.Error(ctx, "failed push binary start client")
+		l.Error(ctx, "Failed to initialize binary upload")
 		return nil, nil, err
 	}
 
@@ -350,7 +350,7 @@ func (c *Client) PushBinary(ctx context.Context, buildID string) (io.WriteCloser
 		},
 	)
 	if err != nil {
-		l.Error(ctx, "failed push binary send buildid chunk")
+		l.Error(ctx, "Failed to send binary upload header", log.Error(err))
 		return nil, nil, err
 	}