feat: use ropey as text buffer backend #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamgent
force-pushed
the
ropey
branch
2 times, most recently
from
9345247 to
3385133
Compare
If the cursor is directly at the first letter of the word, that word's instance should be ignored. Otherwise, we can never traverse backwards in a search, because the textbox does not manually subtract one from the cursor position (and it should never need to, since there can be troublesome edge cases that should be handled by the text buffer, rather than by the textbox).
yamgent
commented
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1.
text_box_impl.rs(continue fromremove_character()ropey.line()returning aString, some data structures can't really return a&str, including rope buffers, as a line content is not guaranteed to be in a contiguous memory space.ropey.ropeycrash if try to insert after the last line.ropeyAdd tests for TextBox(added to Add tests #5).pubvisibilityget_line_len()inTextBoxis confusing, because it is not clear whether it is talking about the byte_len, or fragment_len (the actual length for this method). We should clean it upExplore exposing(not needed for now)char_cursor()if necessary (efficient way of traversing through characters in a line)