Skip to content

Remove .eslintrc.js and use consolidated "eslint-config-yscope"; refactor MenuBar and add settings and help modals. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Feb 29, 2024

References

Previous ESLint configurations have been consolidated into eslint-config-yscope together with new rules.

Description

  1. Remove .eslintrc.js.
  2. Add consolidated "eslint-config-yscope" into devDependencies and use it.
  3. Refactor MenuBar and add settings and help modals.

Validation performed

  1. Ran ESLint on VCS changed files and verified no errors or warnings except for the TODO comments and the unused React variable warning:
    'React' is defined but never used no-unused-vars
    
    The unused React variable can be removed once the we configure babel-loader to use "automatic" transform runtime as documented at https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html .
  2. Configured eventsPerPage and theme in the settings modal and confirmed the new settings work.
  3. Opened the Help modal which correctly displayed the shortcuts help table.

…ctor MenuBar component and add settings and help modals.
@junhaoliao
Copy link
Member Author

Closing this PR as the changes were made to a deprecated version of the log viewer. The functionality / improvements introduced here has already been implemented in the new version of the log viewer, which replaced the codebase in PR #101.

@junhaoliao junhaoliao closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant