fix(state): Disable "Prettify" button in FAST_LOADING state (fixes #249).

[junhaoliao]

Description

The 'Prettify' button is now disabled when the page is in the FAST_LOADING state to prevent user confusion during loading times. This change addresses issue #249.

Checklist

• The PR satisfies the contribution guidelines.
• This is a breaking change and that has been indicated in the PR title, OR this isn't a
  breaking change.
• Necessary docs have been updated, OR no docs need to be updated.

Validation performed

1. Launched debug server with demo file ?filePath=https://yscope.s3.us-east-2.amazonaws.com/sample-logs/yarn-ubuntu-resourcemanager-ip-172-31-17-135.log.1.clp.zst.
2. Clicked the "Prettify" button and observed page loading. During the page load, the "Prettify" button was disabled visually and cannot be clicked, which resolves the concern of requests queuing discussed in Disable "Prettify" button when a page is being loaded. #249 .

Summary by CodeRabbit

• Bug Fixes
  • The Prettify button is now disabled during the fast loading state in the UI.

[coderabbitai]

Walkthrough

The change updates the UI state grid configuration in the codebase, specifically altering the behaviour of the PRETTIFY_BUTTON during the FAST_LOADING state. The button is now set to be disabled in this state, whereas it was previously enabled. No other UI elements or application states are modified, and there are no changes to the declarations or signatures of exported or public entities.

Changes

File(s)	Change Summary
src/typings/states.ts	Updated the UI state grid so that the PRETTIFY_BUTTON is disabled (false) during FAST_LOADING. No other changes made.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant StateGrid

    User->>UI: Triggers FAST_LOADING state
    UI->>StateGrid: Retrieve configuration for FAST_LOADING
    StateGrid-->>UI: PRETTIFY_BUTTON = false
    UI-->>User: PRETTIFY_BUTTON appears disabled

Loading

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de1fac6 and 4bdc65e.

📒 Files selected for processing (1)

• src/typings/states.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}`: - Prefer `false == ` rather than `!`.

**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}: - Prefer false == <expression> rather than !<expression>.

• src/typings/states.ts

🔇 Additional comments (1)

src/typings/states.ts (1)

87-87: Change looks good!

The modification to disable the Prettify button during the FAST_LOADING state directly addresses issue #249 as mentioned in the PR objectives. This prevents users from queuing multiple requests during loading times.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[zzxthehappiest]

Do we want to do it for #251 as well? For example, disable the "Timezone" select dropdown menu during the FAST_LOADING state. I think it is much faster than prettifying but there is still an obvious lag about 0.5s.

[junhaoliao]

Do we want to do it for #251 as well? For example, disable the "Timezone" select dropdown menu during the FAST_LOADING state. I think it is much faster than prettifying but there is still an obvious lag about 0.5s.

Sure. I think disabling the select box will reduce confusion to users.

P.S.: you may notice the log level selector is a similar element to the prettify button and the timezone selector that you're adding, but the log level selector is not disabled during FAST_LOADING. That is because users might quickly select multiple log levels with the checkboxes and we don't want to interrupt their interactions. As a result, allowing those log level filtering requests to be queued was a compromise we had to make.

[Henry8192]

LGTM.