Skip to content

Refactored the menu bar component to move all modal contents to their… #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vishalpalaniappan
Copy link
Contributor

… own respective component.

Description

This change moves the settings and help modal into their own component. This improves readability and allows for the addition of new modals in an organized way. The modal essentially becomes its own self contained interface and this will become more relevant and useful when adding more complex features like managing and executing jobs.

Validation performed

Manually executed all modal functions to ensure that they work as expected.

Henry8192 pushed a commit to Henry8192/yscope-log-viewer that referenced this pull request Jun 23, 2024
Update timezone handling for CLP Single File Archive decoder.
@Henry8192
Copy link
Collaborator

This PR is resolved in our refactored log viewer in #101.

@Henry8192 Henry8192 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants