Refactored the menu bar component to move all modal contents to their… #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… own respetive component
Henry8192
pushed a commit
to Henry8192/yscope-log-viewer
that referenced
this pull request
Jun 23, 2024
Update timezone handling for CLP Single File Archive decoder.
|
This PR is resolved in our refactored log viewer in #101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… own respective component.
Description
This change moves the settings and help modal into their own component. This improves readability and allows for the addition of new modals in an organized way. The modal essentially becomes its own self contained interface and this will become more relevant and useful when adding more complex features like managing and executing jobs.
Validation performed
Manually executed all modal functions to ensure that they work as expected.