-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Add support for finding the log event that's closest to a target timestamp. #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 27 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
ea23947
search timestamp works for unstructured logs
Henry8192 7edaa48
Merge branch 'y-scope:main' into search-timestamp
Henry8192 7481573
Merge branch 'main' into search-timestamp
Henry8192 3ee05a2
fix lint
Henry8192 f1a71a1
implement structured logs search by timestamp
Henry8192 5263385
Merge branch 'main' into search-timestamp
Henry8192 c423ec5
address partial changes from review
Henry8192 467e998
snapshot: get_timestamp seems to be undefined for std::upper_bound
Henry8192 c66cb80
fix lint
Henry8192 89338f7
pass in log_events instead of iterators to generic_get_log_event_inde…
Henry8192 a99ec2a
switch back to std::upper_bound because std::ranges::upper_bound is n…
Henry8192 9ec039f
fix lint
Henry8192 4f125b8
change generic_get_log_event_index_by_timestamp behavior: only return…
Henry8192 5221588
edit docstring for get_log_event_index_by_timestamp
Henry8192 abeb4f8
fix lint
Henry8192 6647fbd
Apply suggestions from code review
Henry8192 046191e
use concept to shorten function definition; minor change to generic_g…
Henry8192 4c7386d
Merge branch 'main' into search-timestamp
Henry8192 c400361
fix lint & syntax
Henry8192 ca4a616
rename get_log_event_index_by_timestamp to get_log_event_idx_by_times…
Henry8192 9443ba3
revert comments and plan to fix in the next pr
Henry8192 db60efd
add back the missing space
Henry8192 0e3e21b
revert decode_range (without creating concept)
Henry8192 412b96e
address changes from Marco's review
Henry8192 54c7df1
remove unnecessary require statement for get_log_event_idx_by_timestamp
Henry8192 eff1849
address the rest of the comments
Henry8192 00f89d4
address code review changes
Henry8192 122f1cf
fix lint
Henry8192 f4a0207
resolve the rest of the conflicts
Henry8192 46fa81f
revert the CMakeList Change
Henry8192 8c8c42e
address kirk's comments in the code review
Henry8192 a984d7b
revert function name to find_nearest_log_event_by_timestamp
Henry8192 4788157
amend find_nearest_log_event_by_timestamp's comments, warning this fu…
Henry8192 ba1b01a
Update src/clp_ffi_js/ir/StreamReader.hpp
Henry8192 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Henry8192 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Henry8192 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Henry8192 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.