XWIKI-23654: Convert finder.less to CSS #4789
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23654
Changes
Description
Clarifications
Screenshots & Video
We can see on these screenshots that the updated CSS file was working as expected on my test instance:
Executed Tests
Built the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-webjar -Pqualitythen used the build on my local instance (see screenshots above). The LESS compilation step is not necessary when building anymore, but the result of the build is pretty much the same as before: onefinder.min.cssfile and onefinder.cssfile.When looking for uses of this file, I could only find references to
finder.min.css: https://github.com/search?q=repo%3Axwiki%2Fxwiki-platform%20finder.min.css&type=codeAll of still worked as expected.
Expected merging strategy