New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Code style: use for loops instead of .forEach() #690

Open

ClementEXWiki wants to merge 1 commit into xwiki-contrib:main from ClementEXWiki:misc-use-for-loops

Contributor

ClementEXWiki commented Feb 20, 2025

Jira URL

N/A

Changes

Description

Use for..of loops instead of .forEach()

Clarifications

for..of loops are faster at runtime

Screenshots & Video

N/A

Executed Tests

N/A

Expected merging strategy

Prefers squash: Yes
Backport on branches:
- N/A


          [Misc] Code style: use for loops instead of .forEach()

596129e

Contributor

manuelleduc commented Feb 20, 2025

Thanks!
A is important to also add the corresponding eslint rules (e.g., https://github.com/github/eslint-plugin-github/blob/main/docs/rules/array-foreach.md) when they exist.
The same is true for the other PRs of the same kind.

manuelleduc self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet