[Misc] Code style: use arrow functions

core/backends/backend-github/src/githubStorage.ts

@@ -61,7 +61,7 @@ export class GitHubStorage extends AbstractStorage {
     return `${this.wikiConfig.baseRestURL}${directory}${image}`;
   }
 
-  hashCode = function (str: string): string {
+  hashCode = (str: string): string => {
     let hash = 0,
       i,
       chr;

core/markdown/markdown-default/src/parseInternalImages.ts

@@ -173,9 +173,8 @@ export function parseInternalImages(
   modelReferenceParser: ModelReferenceParser,
   remoteURLSerializer: RemoteURLSerializer,
 ): MarkdownIt.Core.RuleCore {
-  return function (state: StateCore): void {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    state.tokens.forEach((blockToken: any) => {
+  return (state) => {
+    state.tokens.forEach((blockToken) => {
       if (blockToken.type == "inline") {
         handleInlineBlockToken(
           blockToken,

core/markdown/markdown-default/src/parseInternalLinks.ts

@@ -196,9 +196,8 @@ export function parseInternalLinks(
   modelReferenceParser: ModelReferenceParser,
   remoteURLSerializer: RemoteURLSerializer,
 ): MarkdownIt.Core.RuleCore {
-  return function (state: StateCore): void {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    state.tokens.forEach((blockToken: any) => {
+  return (state) => {
+    state.tokens.forEach((blockToken) => {
       if (blockToken.type == "inline") {
         handleInlineBlockToken(
           blockToken,

core/tiptap-extensions/tiptap-extension-image/src/CristalTiptapImage.ts

@@ -41,10 +41,10 @@ function serializeExternal(node: Node, state: MarkdownSerializerState) {
  * We need to override the default image view to be able to easily add widgets (i.e., visual elements that are not
  * part of the persisted DOM) using Vue.
  */
-const initTiptapImage = function (
+const initTiptapImage = (
   serializer: ModelReferenceSerializer,
   parser: RemoteURLParser,
-) {
+) => {
   function parseLink(mark: Node): EntityReference | undefined {
     try {
       return parser.parse(mark.attrs.src as string);

editors/tiptap/src/components/extensions/link-suggest.ts

@@ -112,11 +112,11 @@ function initSuggestionsService(
   // Return an array of suggestions from a query
   // TODO: reduce the number of statements in the following method and reactivate the disabled eslint rule.
   // eslint-disable-next-line max-statements
-  return async function ({
+  return async ({
     query,
   }: {
     query: string;
-  }): Promise<LinkSuggestionActionDescriptor[]> {
+  }): Promise<LinkSuggestionActionDescriptor[]> => {
     // TODO: add upload attachment action
     // TODO: add create new page action
     // TODO: add links suggestions

editors/tiptap/src/extensions/link.ts

@@ -76,7 +76,7 @@ export default function initLinkExtension(
                 return "[";
               }
             },
-            close: function (state: unknown, mark: Mark) {
+            close: (state: unknown, mark: Mark) => {
               if (parseLink(mark)) {
                 return `|${serializer.serialize(parser.parse(mark.attrs.href))}]]`;
               } else {

editors/tiptap/src/extensions/markdown.ts

@@ -27,10 +27,10 @@ import { RemoteURLSerializer } from "@xwiki/cristal-model-remote-url-api";
 import MarkdownIt from "markdown-it";
 import { Markdown } from "tiptap-markdown";
 
-export default function (
+export default (
   modelReferenceParser: ModelReferenceParser,
   remoteURLSerializer: RemoteURLSerializer,
-) {
+) => {
   return Markdown.extend({
     onBeforeCreate() {
       const content = this.editor.options.content;
@@ -56,4 +56,4 @@ export default function (
         this.editor.storage.markdown.parser.parse(content);
     },
   });
-}
+};

sharedworker/impl/src/components/defaultQueueWorker.ts

@@ -78,7 +78,7 @@ export default class DefaultQueueWorker implements QueueWorker {
         // eslint-disable-next-line @typescript-eslint/no-this-alias
         const that = this;
         this.workerInstance.setPageLoadedCallback(
-          Comlink.proxy(function (page: string) {
+          Comlink.proxy((page) => {
             that.pageLoaded(page);
           }),
         );

skin/src/vue/c-field.vue

@@ -68,9 +68,7 @@ export default defineComponent({
         .get();
       logger?.debug("Ready to get edit field", props.name);
       editFieldValue.value = "";
-      storage.getEditField(document, props.name).then(function (
-        editField: string,
-      ) {
+      storage.getEditField(document, props.name).then((editField: string) => {
         editFieldValue.value = editField;
       });
     } else {

skin/src/vue/contentTools.ts

@@ -107,6 +107,7 @@ export class ContentTools {
     const contentToInject = range.createContextualFragment(html);
     contentToInject
       .querySelectorAll("link[href], script[src]")
+<<<<<<< HEAD
       // TODO get rid of any
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
       .forEach(function (resource: any) {
@@ -121,14 +122,28 @@ export class ContentTools {
             return null;
           }
         });
+=======
+      .forEach((resource) => {
+        url1 = resource.getAttribute("src") ?? resource.getAttribute("ref");
+        document
+          .querySelectorAll("link[href], script[src]")
+          .forEach((resource2) => {
+            const url2 =
+              resource2.getAttribute("src") ?? resource2.getAttribute("href");
+
+            if (url1 && url1 == url2) {
+              return null;
+            }
+          });
+>>>>>>> ad4c7cd7 ([Misc] Code style: use arrow functions)
       });
     return url1;
   }
 
   public static transformImages(cristal: CristalApp, element: string): void {
     const xwikiContentEl = document.getElementById(element);
     if (xwikiContentEl) {
-      const transform = function (img: HTMLImageElement | HTMLScriptElement) {
+      const transform = (img: HTMLImageElement | HTMLScriptElement) => {
         const srcItem = img.attributes.getNamedItem("src");
         if (srcItem) {
           ContentTools.logger?.debug("Found image with url ", srcItem.value);
@@ -148,7 +163,7 @@ export class ContentTools {
           }
         }
       };
-      new MutationObserver(function (mutations: Array<MutationRecord>) {
+      new MutationObserver((mutations) => {
         ContentTools.logger?.debug("Called in mutation records");
         for (const { addedNodes } of mutations) {
           addedNodes.forEach((addedNode) => {
@@ -171,7 +186,7 @@ export class ContentTools {
    * Experimental function to transform scripts
    */
   public static transformScripts(): void {
-    const transformScript = function (scriptEl: HTMLScriptElement) {
+    const transformScript = (scriptEl: HTMLScriptElement) => {
       const srcItem = scriptEl.attributes.getNamedItem("src");
       if (srcItem) {
         ContentTools.logger?.debug(
@@ -197,7 +212,7 @@ export class ContentTools {
       }
     };
 
-    new MutationObserver(function (mutations: Array<MutationRecord>) {
+    new MutationObserver((mutations) => {
       ContentTools.logger?.debug("Called in mutation records");
       for (const { addedNodes } of mutations) {
         addedNodes.forEach((addedNode) => {

xwiki/remoteinlineeditor/src/vue/c-edit-xwikiremote.vue

@@ -74,7 +74,7 @@ export default {
           let path = "/" + cristal?.getCurrentPage() + "/view";
           logger?.debug("pushing path in router", path);
           cristal?.getRouter().push({ path: path });
-          cristal?.loadPage().then(function () {});
+          cristal?.loadPage().then(() => { });
         }
       },
       false,