-
Notifications
You must be signed in to change notification settings - Fork 19
Added shell scripts #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
launch.sh
Outdated
| assert_success chmod +x start_xwiki.sh | ||
|
|
||
| assert_success ./start_xwiki.sh & | ||
| assert_success curl --retry 5 --retry-delay 10 "$checkAddress" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this retry is very useful, Jetty unfortunately does not accept input URL until it's fully started and this takes a little while. At least the first check will definitely fail. Would probably make more sense to put that after the sleep 60.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make it infinity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://curl.haxx.se/docs/manpage.html#--retry-max-time here said that you can replace --retry with --retry-max-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InsanusMokrassar I think we should make the first call only after 60seconds.
Send Notification command is not found(line 7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make it infinity?
The retry is fine like this IMO, it's just started way too early. I would just move the sleep before that line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InsanusMokrassar I think we should make the first call only after 60seconds.
Ok, so, you can add sleep 60 on some line, @somenath1435
|
Send notification command not found error coming(echo working) and we should only do curl once after 60sec(working just fine) |
launch.sh
Outdated
| assert_success chmod +x start_xwiki.sh | ||
|
|
||
| assert_success ./start_xwiki.sh & | ||
| assert_success curl --retry 5 --retry-delay 10 "$checkAddress" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InsanusMokrassar I think we should make the first call only after 60seconds.
Ok, so, you can add sleep 60 on some line, @somenath1435
Added shell script to download and initialize xwiki demo package and run the scripts before performing UI tests.