Skip to content

Conversation

somenath1435
Copy link
Contributor

Added shell script to download and initialize xwiki demo package and run the scripts before performing UI tests.

launch.sh Outdated
assert_success chmod +x start_xwiki.sh

assert_success ./start_xwiki.sh &
assert_success curl --retry 5 --retry-delay 10 "$checkAddress"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this retry is very useful, Jetty unfortunately does not accept input URL until it's fully started and this takes a little while. At least the first check will definitely fail. Would probably make more sense to put that after the sleep 60.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make it infinity?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://curl.haxx.se/docs/manpage.html#--retry-max-time here said that you can replace --retry with --retry-max-time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InsanusMokrassar I think we should make the first call only after 60seconds.
Send Notification command is not found(line 7)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make it infinity?

The retry is fine like this IMO, it's just started way too early. I would just move the sleep before that line.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InsanusMokrassar I think we should make the first call only after 60seconds.

Ok, so, you can add sleep 60 on some line, @somenath1435

@somenath1435
Copy link
Contributor Author

Send notification command not found error coming(echo working) and we should only do curl once after 60sec(working just fine)

launch.sh Outdated
assert_success chmod +x start_xwiki.sh

assert_success ./start_xwiki.sh &
assert_success curl --retry 5 --retry-delay 10 "$checkAddress"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InsanusMokrassar I think we should make the first call only after 60seconds.

Ok, so, you can add sleep 60 on some line, @somenath1435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants