Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client ip to address list #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

man20820
Copy link

for firewall purpose

@xterm-inator
Copy link
Owner

Hey,

Thanks for the merge request. I am currently working on some code that will effect this, which should be done in the next few days.

There is an issue with using auth()->user() as admins can create wireguard peers for users which then the wrong email would be used. However the change I'm currently working on which is changing to using usernames instead of emails as well as using the new name field on the mikrotik wireguard peers which should fix this issue as then the name could be used for the address list also.

Also should probably add a config option to enable this as not everyone might want to create address lists. This could be done with adding another option in the api/config/services.php file in the wirequard array 'add_peers_to_address_list' => env('ROUTEROS_WIREGUARD_ADD_PEERS_TO_ADDRESS_LIST', false) or something like that, then only doing the actions if that is true using config('services.wireguard.add_peers_to_address_list')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants