-
Notifications
You must be signed in to change notification settings - Fork 16
Update xtensor #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xtensor #147
Conversation
|
Thanks for opening this one! I'll fix the CI in a dedicated PR so that you can rebase yours. |
|
The CI has been fixed, you can now rebase your PR. I've removed the environement-dev-win.yml file because it was to used anywhere. |
64789f1 to
1413148
Compare
6650821 to
2d89b62
Compare
|
Thanks! It seems to work now, but I had to upgrade Xtensor.R in a fork. I opened a pull request for that fix in xtensor-stack/Xtensor.R#39. |
Thanks for doing it. I'm going to fix the CI there so that we can merge your PR, and then merge this one. Thanks again for your patience!
I think it should be done in a dedicated PR. This way we can release xtensor-r compatible with xtensor 0.26 before upgrading to xtensor 0.27 |
75fe847 to
2d89b62
Compare
|
Thanks for fixing the CI in Xtensor.R! |
|
Apparently Xtensor.R needs additional fixes (and I noticed that the xtensor packages were removed from CRAN, that should be investigated and fixed somehow), but I don't want to block this PR longer. So let's use your fork of Xtensor.R here until everything is fixed upstream. |
|
Unless you have additional changes to push, feel free to mark this one as Ready for review so that I can merge it and tag a release of xtensor-r. |
|
Yes, it appears that xtensor-stack/Xtensor.R#39 is currently failing in CI due to a dependency on xtensor-r. |
CRAN submission can certainly be challenging when dealing with complex workflows. You might be interested in R-Universe (https://r-universe.dev/search). We use it ourselves for the evalhyd R package, which is based on xtensor (https://hydrogr.r-universe.dev/evalhyd). |
|
Thanks again for your work on this and your patience! |
Hi, as xtensor-python, xtensor-r needs to be updated after xtensor-stack/xtensor#2829.