Skip to content

Conversation

@fbourgin
Copy link
Contributor

@fbourgin fbourgin commented Oct 30, 2025

Hi, as xtensor-python, xtensor-r needs to be updated after xtensor-stack/xtensor#2829.

@JohanMabille
Copy link
Member

Thanks for opening this one! I'll fix the CI in a dedicated PR so that you can rebase yours.

@JohanMabille
Copy link
Member

JohanMabille commented Nov 3, 2025

The CI has been fixed, you can now rebase your PR. I've removed the environement-dev-win.yml file because it was to used anywhere.

@fbourgin fbourgin marked this pull request as draft November 5, 2025 14:46
@fbourgin
Copy link
Contributor Author

fbourgin commented Nov 5, 2025

Thanks! It seems to work now, but I had to upgrade Xtensor.R in a fork. I opened a pull request for that fix in xtensor-stack/Xtensor.R#39.
Should that PR also include the upgrade to xtensor 0.27 and C++20, or would you prefer that in a separate PR?

@fbourgin fbourgin marked this pull request as ready for review November 5, 2025 20:24
@JohanMabille
Copy link
Member

JohanMabille commented Nov 5, 2025

Thanks! It seems to work now, but I had to upgrade Xtensor.R in a fork.

Thanks for doing it. I'm going to fix the CI there so that we can merge your PR, and then merge this one. Thanks again for your patience!

Should that PR also include the upgrade to xtensor 0.27 and C++20, or would you prefer that in a separate PR?

I think it should be done in a dedicated PR. This way we can release xtensor-r compatible with xtensor 0.26 before upgrading to xtensor 0.27

@fbourgin fbourgin force-pushed the update_xtensor branch 2 times, most recently from 75fe847 to 2d89b62 Compare November 14, 2025 16:09
@fbourgin fbourgin marked this pull request as draft November 18, 2025 16:00
@fbourgin
Copy link
Contributor Author

Thanks for fixing the CI in Xtensor.R!
If xtensor-stack/Xtensor.R#39 looks good to you, I think it's ready to be merged.
I also have a separate PR ready for the xtensor 0.27 update.

@JohanMabille
Copy link
Member

JohanMabille commented Nov 20, 2025

Apparently Xtensor.R needs additional fixes (and I noticed that the xtensor packages were removed from CRAN, that should be investigated and fixed somehow), but I don't want to block this PR longer. So let's use your fork of Xtensor.R here until everything is fixed upstream.

@JohanMabille
Copy link
Member

Unless you have additional changes to push, feel free to mark this one as Ready for review so that I can merge it and tag a release of xtensor-r.

@fbourgin
Copy link
Contributor Author

Yes, it appears that xtensor-stack/Xtensor.R#39 is currently failing in CI due to a dependency on xtensor-r.
I can try to fix that after the update to xtensor-r is complete.
I believe this PR is now ready to be merged.

@fbourgin fbourgin marked this pull request as ready for review November 20, 2025 15:42
@fbourgin
Copy link
Contributor Author

Apparently Xtensor.R needs additional fixes (and I noticed that the xtensor packages were removed from CRAN, that should be investigated and fixed somehow), but I don't want to block this PR longer. So let's use your fork of Xtensor.R here until everything is fixed upstream.

CRAN submission can certainly be challenging when dealing with complex workflows. You might be interested in R-Universe (https://r-universe.dev/search). We use it ourselves for the evalhyd R package, which is based on xtensor (https://hydrogr.r-universe.dev/evalhyd).

@JohanMabille
Copy link
Member

Thanks again for your work on this and your patience!

@JohanMabille JohanMabille merged commit 7ffdfda into xtensor-stack:master Nov 20, 2025
9 checks passed
@fbourgin fbourgin deleted the update_xtensor branch November 20, 2025 19:37
@fbourgin fbourgin mentioned this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants