Skip to content

Adding examples (full-working) #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adding examples (full-working) #218

wants to merge 1 commit into from

Conversation

tdegeus
Copy link
Member

@tdegeus tdegeus commented Nov 9, 2019

I'm starting adding some full-working examples to the docs. At first I will implement the strategies described by @JohanMabille here

I'm still having trouble getting the first example working, in particular the CMakeLists.txt is apparently insufficient as ~/miniconda3/envs/test/include/xtensor-python/pycontainer.hpp:28:10: fatal error: 'numpy/arrayobject.h' file not found

Thereafter it would be good to hear your opinions on what kind of examples to include @wolfv @JohanMabille @SylvainCorlay. If you agree I would probably include building the example in the CI.

@wolfv
Copy link
Member

wolfv commented Nov 11, 2019

Cool! If you use this CMake file here: https://github.com/xtensor-stack/xtensor-python/blob/master/cmake/FindNumPy.cmake

I think it should help in finding the include directory for the NumPy headers.

@tdegeus
Copy link
Member Author

tdegeus commented Nov 11, 2019

Thanks @wolfv . By default my cmake does not find the FindNumPy.cmake when I install xtensor-python with conda. I.e. with

find_package(NumPy REQUIRED)

I get

CMake Warning at CMakeLists.txt:9 (find_package):
  By not providing "FindNumPy.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "NumPy", but
  CMake did not find one.

  Could not find a package configuration file provided by "NumPy" with any of
  the following names:

    NumPyConfig.cmake
    numpy-config.cmake

  Add the installation prefix of "NumPy" to CMAKE_PREFIX_PATH or set
  "NumPy_DIR" to a directory containing one of the above files.  If "NumPy"
  provides a separate development package or SDK, be sure it has been
  installed.

@tdegeus
Copy link
Member Author

tdegeus commented May 18, 2021

Integrated in #256

@tdegeus tdegeus closed this May 18, 2021
@tdegeus tdegeus deleted the docs branch May 18, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants