Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting adding some full-working examples to the docs. At first I will implement the strategies described by @JohanMabille here
I'm still having trouble getting the first example working, in particular the
CMakeLists.txt
is apparently insufficient as~/miniconda3/envs/test/include/xtensor-python/pycontainer.hpp:28:10: fatal error: 'numpy/arrayobject.h' file not found
Thereafter it would be good to hear your opinions on what kind of examples to include @wolfv @JohanMabille @SylvainCorlay. If you agree I would probably include building the example in the CI.