Skip to content

Conversation

@neriyaco
Copy link
Member

No description provided.

@neriyaco neriyaco requested a review from Copilot March 29, 2025 22:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a version bump step in the GitHub Actions workflow to automatically update the version file during a release along with minor code style improvements and dependency injection updates.

  • Updates CSS modules tests to use snake_case class names
  • Modifies relative CSS path handling and dependency injection key in the core modules
  • Adds steps in the workflow to bump, commit, and push the version based on the release tag

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
tests/test_css_modules.py Updated tests to reflect snake_case naming for CSS module classes
src/pydom/styling/css_modules.py Adjusted relative path handling for CSS imports
src/pydom/context/context.py Changed dependency injection mapping key from Context to type(self)
.github/workflows/python-publish.yml Updated permissions and added steps for version bump automation
Files not reviewed (1)
  • tests/css/styles.css: Language not supported
Comments suppressed due to low confidence (2)

src/pydom/context/context.py:33

  • Changing the injector key from 'Context' to 'type(self)' may alter the dependency resolution behavior. Verify that this change is intentional and aligns with the overall design of the dependency injection system.
type(self): self,

.github/workflows/python-publish.yml:8

  • [nitpick] Increasing the permission from 'read' to 'write' for repository contents enables commit operations. Ensure that this permission change is acceptable within your repository security policies.
contents: write

@neriyaco neriyaco merged commit 9cd1a9c into main Mar 29, 2025
6 checks passed
@neriyaco neriyaco deleted the add-version-bump-in-workflow branch March 29, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant