-
Notifications
You must be signed in to change notification settings - Fork 2
Add async function extensions for coroutine objects #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: neriyaco <42520786+neriyaco@users.noreply.github.com>
Co-authored-by: neriyaco <42520786+neriyaco@users.noreply.github.com>
Co-authored-by: neriyaco <42520786+neriyaco@users.noreply.github.com>
binyamin555
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@copilot tests are failing |
Co-authored-by: binyamin555 <42520501+binyamin555@users.noreply.github.com>
binyamin555
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR breaks support for older versions of Python (due to typing).
Please make sure you're using only types from typing and typing_extensions, including the usage of Type and Union.
Co-authored-by: binyamin555 <42520501+binyamin555@users.noreply.github.com>
Fixed in 2e969bd. Replaced all Python 3.10+ union syntax ( |
Plan for Adding Async Function Extensions
src/extype/builtin_extensions/coroutine_ext.pywiththenandcatchextension methods for coroutine objectsextend_all.pyto auto-importtests/test_builtin_extensions.pyfor async extensionsSummary
Successfully implemented async function extensions for coroutines with:
then(fn): Maps awaitable results through sync or async functionscatch(fn, exception=Exception): Handles exceptions with sync or async error handlersOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.