Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache): add in-memory lru cache for signature verification #1625

Merged
merged 13 commits into from
Feb 18, 2025
Merged

feat(cache): add in-memory lru cache for signature verification #1625

merged 13 commits into from
Feb 18, 2025

Conversation

fbac
Copy link
Contributor

@fbac fbac commented Feb 12, 2025 •
edited
Loading

Closes #1126

@fbac fbac force-pushed the cache-valid-signatures branch from 7a25b18 to 8f9cdb6 Compare February 12, 2025 18:08
codabrink
codabrink reviewed Feb 12, 2025
View reviewed changes
@fbac
Wrap MultiSmartContractVerifier into CachedContractSignatureVerifier
c412d9c 
- Create a CacheContractSifnatureVerifier which implements SmartContractSignatureVerifier
- Move all the logic to mls_validation_service
@fbac fbac requested review from codabrink and insipx February 14, 2025 16:12
@codabrink
Copy link
Contributor

Really good so far, very close!

@fbac fbac force-pushed the cache-valid-signatures branch from 573824e to 503810a Compare February 14, 2025 17:32
@fbac fbac force-pushed the cache-valid-signatures branch from 9734bc1 to 49d5294 Compare February 17, 2025 15:30
@fbac fbac force-pushed the cache-valid-signatures branch from d566ce7 to 01bce53 Compare February 17, 2025 16:09
@fbac fbac marked this pull request as ready for review February 17, 2025 16:16
@fbac fbac requested a review from a team as a code owner February 17, 2025 16:16
@fbac fbac requested a review from codabrink February 17, 2025 16:16
@fbac fbac force-pushed the cache-valid-signatures branch from eda1791 to de1e436 Compare February 17, 2025 17:18
codabrink
codabrink approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@codabrink codabrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@fbac fbac merged commit 7d6b8b1 into main Feb 18, 2025
11 checks passed
@fbac fbac deleted the cache-valid-signatures branch February 18, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codabrink codabrink codabrink approved these changes

@insipx insipx Awaiting requested review from insipx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caching SCW Verifier for server-side use
3 participants
@fbac @codabrink @insipx