Auto-update imgui-file-dialog to v0.6.8 #8522
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the process of keeping project dependencies current by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an automated update for the imgui-file-dialog package to version v0.6.8. The change correctly adds the new version and its corresponding SHA256 hash to the xmake.lua file. The modification is consistent with the project's versioning conventions, placing the newest version at the top of the list. The change is straightforward and appears correct, so I have no specific feedback.
|
mingw|i386 D:\a\_temp\msys64\mingw32\bin\i686-w64-mingw32-g++ -c -m32 -fvisibility=hidden -fvisibility-inlines-hidden -O3 -std=c++11 -IC:\Users\runneradmin\AppData\Local\.xmake\packages\i\imgui\v1.92.1\3bdc092daea44cc08fbc6e4419da4de5\include -IC:\Users\runneradmin\AppData\Local\.xmake\packages\i\imgui\v1.92.1\3bdc092daea44cc08fbc6e4419da4de5\include\imgui -IC:\Users\runneradmin\AppData\Local\.xmake\packages\i\imgui\v1.92.1\3bdc092daea44cc08fbc6e4419da4de5\include\backends -IC:\Users\runneradmin\AppData\Local\.xmake\packages\i\imgui\v1.92.1\3bdc092daea44cc08fbc6e4419da4de5\include\misc\cpp -DNDEBUG -o build_07c0fb8b\.objs\imgui-file-dialog\mingw\i386\release\ImGuiFileDialog.cpp.obj ImGuiFileDialog.cpp
checking for flags (-MMD -MF) ... ok
> i686-w64-mingw32-g++.exe "-MMD" "-MF" "D:\a\_temp\msys64\tmp\.xmake\251031\_65839d841f2b1898d730778473c26a47" "-m32"
error: @programdir\core\main.lua:272: @programdir\actions\build\main.lua:161: @programdir\modules\async\runjobs.lua:392: @programdir\modules\private\action\build\object.lua:100: @programdir\modules\core\tools\gcc.lua:1047: ImGuiFileDialog.cpp: In member function 'virtual std::vector<IGFD::FileInfos> FileSystemDirent::ScanDirectory(const std::string&)':
ImGuiFileDialog.cpp:781:54: error: cannot convert '_stat64*' to '_stat32i64*'
781 | if (!_wstati64(wfpn.c_str(), &sb)) {
| ^~~
| |
| _stat64*
In file included from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/cwchar:49,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/bits/postypes.h:42,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/bits/char_traits.h:44,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/string:44,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/bitset:54,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/regex:42,
from ImGuiFileDialog.h:206,
from ImGuiFileDialog.cpp:29:
D:/a/_temp/msys64/mingw32/include/wchar.h:268:75: note: initializing argument 2 of 'int _wstat32i64(const wchar_t*, _stat32i64*)'
268 | _CRTIMP int __cdecl _wstat32i64(const wchar_t *_Name,struct _stat32i64 *_Stat);
| ~~~~~~~~~~~~~~~~~~~^~~~~
ImGuiFileDialog.cpp: In member function 'virtual void FileSystemDirent::GetFileDateAndSize(const std::string&, const IGFD::FileType&, std::string&, size_t&)':
ImGuiFileDialog.cpp:831:53: error: cannot convert '_stat64*' to '_stat32i64*'
831 | result = _wstati64(wfpn.c_str(), &statInfos);
| ^~~~~~~~~~
| |
| _stat64*
D:/a/_temp/msys64/mingw32/include/wchar.h:268:75: note: initializing argument 2 of 'int _wstat32i64(const wchar_t*, _stat32i64*)'
268 | _CRTIMP int __cdecl _wstat32i64(const wchar_t *_Name,struct _stat32i64 *_Stat);
| ~~~~~~~~~~~~~~~~~~~^~~~~
ImGuiFileDialog.cpp:844:40: error: cannot convert '__time64_t*' {aka 'long long int*'} to 'const time_t*' {aka 'const long int*'}
844 | struct tm* _tm = localtime(&statInfos.st_mtime);
| ^~~~~~~~~~~~~~~~~~~
| |
| __time64_t* {aka long long int*}
In file included from D:/a/_temp/msys64/mingw32/include/pthread.h:69,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/i686-w64-mingw32/bits/gthr-default.h:35,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/i686-w64-mingw32/bits/gthr.h:157,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/ext/atomicity.h:37,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/bits/locale_classes.h:43,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/locale:43,
from D:/a/_temp/msys64/mingw32/include/c++/15.2.0/regex:43:
D:/a/_temp/msys64/mingw32/include/time.h:241:46: note: initializing argument 1 of 'tm* localtime(const time_t*)'
241 | struct tm *__CRTDECL localtime(const time_t *_Time) __MINGW_ASM_CALL(_localtime32);
| |
New version of imgui-file-dialog detected (package version: v0.6.7, last github version: v0.6.8)