Skip to content

Auto-update onnx to v1.19.1 #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Auto-update onnx to v1.19.1 #8423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/o/onnx/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package("onnx")
add_urls("https://github.com/onnx/onnx/archive/refs/tags/$(version).tar.gz",
"https://github.com/onnx/onnx.git", {submodules = false})

add_versions("v1.19.1", "ce9d2569a61d64e8a3d05b92194f60ffb7c868dbb754a71f5b4d992273a9413d")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this correctly adds the new version, the block of add_versions calls is not consistently sorted, which can make it harder to track version history and maintain the file. For better readability, it's a good practice to keep these version declarations sorted in descending order. This seems to be caused by the auto-update script, which just prepends the new version. A follow-up to sort the existing versions and perhaps adjust the script would be beneficial.

add_versions("v1.18.0", "b466af96fd8d9f485d1bb14f9bbdd2dfb8421bc5544583f014088fb941a1d21e")
add_versions("v1.17.0", "8d5e983c36037003615e5a02d36b18fc286541bf52de1a78f6cf9f32005a820e")
add_versions("v1.16.2", "84fc1c3d6133417f8a13af6643ed50983c91dacde5ffba16cc8bb39b22c2acbb")
Expand Down
Loading